[Asterisk-code-review] res rtp asterisk: Correction for the limit which detects tha... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_rtp_asterisk: Correction for the limit which detects that a packet is SRTP.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Minor comments, this will also need to be cherry picked into 11/13.

https://gerrit.asterisk.org/#/c/428/1//COMMIT_MSG
Commit Message:

Line 7: res_rtp_asterisk: Correction for the limit which detects that a packet is SRTP.
This is actually for DTLS, not SRTP.


Line 9: First byte of SRTP packet shall be in range 20-63, not 20-64. Refer to RFC
Same here.


https://gerrit.asterisk.org/#/c/428/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 2020: 	if ((*in >= 20) && (*in <= 63)) {
I'd refer the RFC here so that if someone is looking they have something to reference.


-- 
To view, visit https://gerrit.asterisk.org/428
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6fa0d72b37c36a27fe40686e0ae6fba3afec31
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Y Ateya <y.ateya at starkbits.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes