[Asterisk-code-review] Better support for RFC3581 (asterisk[master])

Joshua Colp asteriskteam at digium.com
Sun May 10 07:23:37 CDT 2015


Joshua Colp has posted comments on this change.

Change subject: Better support for RFC3581
......................................................................


Patch Set 1: Code-Review-2

This change is incorrect. Altering the configuration of a peer based on communication occurring is bad. As well - 'rport' is used for sending responses to a request. It's not for sending requests. I've updated the ASTERISK-25071 issue with a request for configuration.

-- 
To view, visit https://gerrit.asterisk.org/427
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab4469db0dc5f9535f2a90ec5bb5ba2f1cf527a6
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Oleg Rabinovich <olegrtecno at gmail.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list