[Asterisk-code-review] Allow command-line options to override asterisk.conf. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Allow command-line options to override asterisk.conf.
......................................................................


Patch Set 2:

> Since this is a major change in behaviour, it should be noted at
 > least in CHANGES. It may also warrant a snippet in UPGRADE.

I've added a bullet point to CHANGES and copied it to UPDATE.txt.  Writing this prompted me to question the way -X works.  Currently -X will enable #exec for asterisk.conf load.  If asterisk.conf doesn't set execincludes, the -X option will apply to the whole system.

The new update causes -X to apply for the load of asterisk.conf only.  To use #exec within any other config load, asterisk.conf needs execincludes=yes.  The man page and 'asterisk -h' are updated to reflect this.  The previous help about -X wasn't completely clear that it could apply to the whole system, we may want to consider patching the help for 11 and 13.

-- 
To view, visit https://gerrit.asterisk.org/392
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1450d45c15b4467274b871914d893ed4f6564cd7
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No