[Asterisk-code-review] Fix crash in codec lpc10 when MALLOC DEBUG is enabled. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Fri May 8 16:33:54 CDT 2015


Corey Farrell has posted comments on this change.

Change subject: Fix crash in codec_lpc10 when MALLOC_DEBUG is enabled.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/409/1/codecs/lpc10/lpcini.c
File codecs/lpc10/lpcini.c:

Line 37: #include "asterisk.h"
> These are available to Asterisk modules to deal with external modules that 
I'm aware of those other procedures.  I'm not sure how I feel about treating lpc10 code as external.  Either way my impression of the code is that it was previously intended for this source to use Asterisk allocators, so I'd prefer to not change that.  For now this is just a bug fix / get it back to the way things were.  The addition of WRAP_LIBC_MALLOC fixes an issue caused by commit 37179a2b1f0a12e063a2bb300e402ac5e7512569 where codec_lpc10 would fail runtime link do to lack of Do_not_use_malloc_... symbol when MALLOC_DEBUG is enabled.


-- 
To view, visit https://gerrit.asterisk.org/409
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74f63fd09fdeb673ee7753122c3bb4722ab6e1ac
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list