[Asterisk-code-review] cdr/cdr adaptive odbc.c: Set character for quoted identifiers. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: cdr/cdr_adaptive_odbc.c: Set character for quoted identifiers.
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

One minor finding.

https://gerrit.asterisk.org/#/c/246/6/cdr/cdr_adaptive_odbc.c
File cdr/cdr_adaptive_odbc.c:

Line 106: 	int lenconnection, lentable, lenschema, lenquoted_identifiers, usegmtime = 0;
lenquoted_identifiers looks to be unused, so it should be removed.

Note, if you configure asterisk using --enable-dev-mode it will turn any unused variable warnings into compile time errors, so they become easier to spot.


-- 
To view, visit https://gerrit.asterisk.org/246
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b9a56b79ca13a727a803d88ed3b8643e37632b8
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes