[Asterisk-code-review] res rtp asterisk: Issue NOTICE if res srtp is not found. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: res_rtp_asterisk: Issue NOTICE if res_srtp is not found.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/410/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 1273: 		ast_log(LOG_NOTICE, "SRTP support module is not loaded or available. Try loading res_srtp.so.\n");
Nit-pick: s/SRTP support/DTLS-SRTP support/.

This would make it easier to see the association between this message and the one that will follow (from res_pjsip_sdp_rtp.c).

Also LOG_NOTICE?  Seems like this is worthy of a LOG_ERROR.  The message from res_pjsip_sdp_rtp is a LOG_ERROR, so doing the same would also make it easier to see the two messages as being 'together'.


-- 
To view, visit https://gerrit.asterisk.org/410
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13aa477b47b299876728a21b130998a0ea6cd19f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes