[Asterisk-code-review] Fix crash in codec lpc10 when MALLOC DEBUG is enabled. (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Fri May 8 11:19:46 CDT 2015


Richard Mudgett has posted comments on this change.

Change subject: Fix crash in codec_lpc10 when MALLOC_DEBUG is enabled.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/409/1/codecs/lpc10/lpcini.c
File codecs/lpc10/lpcini.c:

Line 37: #include "asterisk.h"
These are available to Asterisk modules to deal with external modules that allocate memory and don't know about MALLOC_DEBUG.

void *ast_std_malloc(size_t size);
void *ast_std_calloc(size_t nmemb, size_t size);
void *ast_std_realloc(void *ptr, size_t size);
void ast_std_free(void *ptr);

Would it be better to treat the lpc10 code as external and account for it in the Asterisk files?


-- 
To view, visit https://gerrit.asterisk.org/409
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74f63fd09fdeb673ee7753122c3bb4722ab6e1ac
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list