[Asterisk-code-review] contrib/editors: Correct syntax highlighting for comments in... (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: contrib/editors: Correct syntax highlighting for comments in vim
......................................................................


Patch Set 1:

> > 1) Use an escaped semicolon in extensions.conf, for example:
 > > exten => _1XX,1,SIPAddHeader(Call-Info: \;answer-after=0)
 > >
 > > Without the patch everything after ; is highlighted as a comment,
 > > which is wrong.
 > >
 > > 2) Use block comments in any config file, like this:
 > > ;--
 > > this line is commented
 > > ;--
 > > this is a nested block comment
 > > --;
 > > [xxx]
 > > this is still a comment
 > > --;
 > >
 > > ;----  this is a single line comment, ";---" is an exception and
 > > does not start a block
 > > [not_commented]
 > > x=1
 > >
 > > Block comments were not supported at all.
 > 
 > Ah, conf files. Can you update the commit message just so it's
 > clear that this applies to conf files?  Also, cherry-pick this to
 > 13.

This is arguably a bug fix, so I'd say 11 as well.

-- 
To view, visit https://gerrit.asterisk.org/354
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id17dfaeda8ed4be572e8107a0c010066584aaee7
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No