[Asterisk-code-review] digium commits: Add a function that returns a change log entry (repotools[master])

[Samuel Galarneau]

Samuel Galarneau has posted comments on this change.

Change subject: digium_commits: Add a function that returns a change log entry
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/380/2/digium_commits.py
File digium_commits.py:

Line 208: text = "{0} [{1}]  {2}\n\n".format(
        :             datetime.fromtimestamp(self.raw.authored_date).strftime(
        :                     '%Y-%m-%d %H:%M +0000'),
        :             self.raw.hexsha[:10],
        :             ",".join([str(coder) for coder in self.get_coders()]))
The formatting here makes this hard to read. I would also separate this statement from the for loop with a blank line.


Line 220:         return text
Blank line here.


-- 
To view, visit https://gerrit.asterisk.org/380
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58f59c461aeb765f6ead18104f82e8f982c413ae
Gerrit-PatchSet: 2
Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Samuel Galarneau <sgalarneau at digium.com>
Gerrit-HasComments: Yes