[Asterisk-code-review] vector: Additional enhancements and fixes (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: vector:  Additional enhancements and fixes
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/374/4/include/asterisk/vector.h
File include/asterisk/vector.h:

Line 170: 		size_t new_size = ((idx) > (vec)->current ? (idx) : (vec)->current); \
This should just be: size_t new_size = (idx);

The __make_room idx parameter passed by AST_VECTOR_INSERT_AT should be this ternary expression.


https://gerrit.asterisk.org/#/c/374/4/tests/test_vector.c
File tests/test_vector.c:

Line 79: 	/* there should be no vector growth for teh 3 appends */
the


-- 
To view, visit https://gerrit.asterisk.org/374
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05e5e47fd02f61964be13b7e8942bab5d61b29cc
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes