[Asterisk-code-review] res stasis snoop: spying on a single direction continually i... (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Wed May 6 11:56:01 CDT 2015


Hello Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/356

to look at the new patch set (#3).

Change subject: res_stasis_snoop: spying on a single direction continually increases CPU
......................................................................

res_stasis_snoop: spying on a single direction continually increases CPU

Creating a snoop channel in ARI and spying only on a single direction (in or
out) results in CPU utilization continually increasing until the CPU is fully
consumed. This occurs because frames are being put in the opposing direction's
slin factory queue, but not being removed.

Fixed the problem by always reading and disposing of frames from the opposite
queue of the direction selected.

Change-Id: I935bfd15f1db958f364d9d6b3b45582c0113dd60
---
M res/res_stasis_snoop.c
1 file changed, 20 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/56/356/3
-- 
To view, visit https://gerrit.asterisk.org/356
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I935bfd15f1db958f364d9d6b3b45582c0113dd60
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>



More information about the asterisk-code-review mailing list