[Asterisk-code-review] vector: Additional enhancements and fixes (asterisk[master])
George Joseph
asteriskteam at digium.com
Wed May 6 11:14:33 CDT 2015
George Joseph has uploaded a new patch set (#2).
Change subject: vector: Additional enhancements and fixes
......................................................................
vector: Additional enhancements and fixes
After using the new vector stuff for real I found...
A bug in AST_VECTOR_INSERT_AT that could cause a seg fault.
The callbacks needed to be closer to ao2_callback in behavior
WRT to CMP_MATCH and CMP_STOP behavior and the ability to return
a vector of matched entries.
I also added a new macro to test.h that acts like ast_test_validate
but also accepts a return code variable and a cleanup label. As well
as printing the error, it sets the rc variable to AST_TEST_FAIL and
does a goto to the specified label on error. I had a local version
of this in test_vector so I just moved it.
ASTERISK-25045
Change-Id: I05e5e47fd02f61964be13b7e8942bab5d61b29cc
---
M include/asterisk/test.h
M include/asterisk/vector.h
M tests/test_vector.c
3 files changed, 339 insertions(+), 162 deletions(-)
git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/75/375/2
--
To view, visit https://gerrit.asterisk.org/375
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I05e5e47fd02f61964be13b7e8942bab5d61b29cc
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
More information about the asterisk-code-review
mailing list