[Asterisk-code-review] chan unistim: Fix build failure due to ACL changes. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: chan_unistim: Fix build failure due to ACL changes.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/366/1/channels/chan_unistim.c
File channels/chan_unistim.c:

Line 6410: 			if (sub->owner) {
         : 				ast_log(LOG_WARNING,
         : 						"Device '%s' was not deleted : a call is in progress. Try again later.\n",
         : 						d->name);
         : 				return;
         : 			}
         : 		}
         : 		if (sub->subtype == SUB_THREEWAY) {
         : 			ast_log(LOG_WARNING,
         : 					"Device '%s' with threeway call subchannels allocated, aborting.\n",
         : 					d->name);
         : 			return;
Shouldn't these return paths unlock the d->subs list before returning?


-- 
To view, visit https://gerrit.asterisk.org/366
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57081045c72b9fcf12d5c84493278f9272c31b32
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes