[Asterisk-code-review] res stasis snoop: spying with "out" direction only continual... (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Tue May 5 14:05:59 CDT 2015


Hello Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/356

to look at the new patch set (#2).

Change subject: res_stasis_snoop: spying with "out" direction only continually increases CPU
......................................................................

res_stasis_snoop: spying with "out" direction only continually increases CPU

Creating a snoop channel with ARI and specifying "out" only for the spy mode
results in CPU utilization continually increasing until the CPU is fully
consumed. This occurs because frames are being put in the slin read_factory's
queue (the "in" direction not selected, thus ignored), but not being removed.

Fixed the problem by always reading from the "in" direction queue. However,
in the case when specifying "out" only drop the "in" frames.

Change-Id: I935bfd15f1db958f364d9d6b3b45582c0113dd60
---
M res/res_stasis_snoop.c
1 file changed, 17 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/56/356/2
-- 
To view, visit https://gerrit.asterisk.org/356
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I935bfd15f1db958f364d9d6b3b45582c0113dd60
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>



More information about the asterisk-code-review mailing list