[Asterisk-code-review] stasis: Fix dial masquerade datastore lifetime (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: stasis: Fix dial masquerade datastore lifetime
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/357/1/main/stasis_channels.c
File main/stasis_channels.c:

Line 411: 	if (caller) {
        : 		if (forwarded) {
        : 			ast_channel_unlock(forwarded);
        : 		}
        : 		ast_channel_unlock(peer);
        : 		remove_dial_masquerade_caller(caller);
        : 		ast_channel_unlock(caller);
        : 	}
> It appears as if this will remove the dial masquerade datastore on the firs
The remove_dial_masquerade_caller function checks whether there are any dialed targets still remaining, if there are then it won't remove it.

I put that logic in the function because you have to look up the datastore and it didn't feel quite right having it in here.


-- 
To view, visit https://gerrit.asterisk.org/357
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef4ca5ca04980028604cc2af5d2992ac3431b3f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes