[Asterisk-code-review] cdr/cdr adaptive odbc.c: Set character for quoted identifiers. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: cdr/cdr_adaptive_odbc.c: Set character for quoted identifiers.
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/246/5/cdr/cdr_adaptive_odbc.c
File cdr/cdr_adaptive_odbc.c:

Line 85: 	char *quoted_identifiers;
> I still don't quite understand. From the description I understand this feat
I understand why it was done (to match the existing code) but agree with Kevin. If this is only ever going to be a fixed size (and it is, because you have a fixed size elsewhere) you may as well just make this a fixed size as well. You may also want to output an error if the provided value for it exceeds the limit as that would be an incorrect configuration.


-- 
To view, visit https://gerrit.asterisk.org/246
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b9a56b79ca13a727a803d88ed3b8643e37632b8
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes