[Asterisk-code-review] res stasis snoop: spying with "out" direction only continual... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_stasis_snoop: spying with "out" direction only continually increases CPU
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Have you tested this with the MixMonitorMute functionality to ensure that the resulting recording, even when muted, is fine? Previously there would still be a constant stream of media but with this change there won't be.

https://gerrit.asterisk.org/#/c/356/1/main/audiohook.c
File main/audiohook.c:

Line 199: 			muteme = 1;
Since you are not adding media to the slinfactory when muted you can probably exit early and not clear the frame or do  the signal.


-- 
To view, visit https://gerrit.asterisk.org/356
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I935bfd15f1db958f364d9d6b3b45582c0113dd60
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes