[Asterisk-code-review] vector: Traversal, retrieval, insert and locking enhancements (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Mon May 4 12:52:02 CDT 2015


Richard Mudgett has posted comments on this change.

Change subject: vector:  Traversal, retrieval, insert and locking enhancements
......................................................................


Patch Set 5: Code-Review-1

I don't think there should be a rwlock version of the vector macros.  This just leads to an explosion of vector macro flavors just like the linked list versions.

Since the vector implementation is entirely done by macro you can easily use any external locking mechanism required.  You can also control how long to hold the lock over a group of vector operations.

-- 
To view, visit https://gerrit.asterisk.org/339
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e07ecc709d2f5f91bcab8904e5e9340609b00e0
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list