[Asterisk-code-review] CLI: Enable automatic references to modules. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: CLI: Enable automatic references to modules.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/337/1/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 1153: int __ast_res_pjsip_init_options_handling(const struct ast_module_info *ast_module_info)
MIght be clearer to leave the reload flag and have the macro pass in module_info in addition to it.  It took me a few minutes to understand why qualify_and_reschedule_all was dependent on module_info being passed in.


-- 
To view, visit https://gerrit.asterisk.org/337
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7aafc7c9f2b912918f28fe51d51e9e8a755750e3
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-HasComments: Yes