[Asterisk-code-review] res pjsip dlg options: Fix MODULEINFO section. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Sat May 2 02:22:31 CDT 2015


Corey Farrell has uploaded a new change for review.

  https://gerrit.asterisk.org/335

Change subject: res_pjsip_dlg_options: Fix MODULEINFO section.
......................................................................

res_pjsip_dlg_options: Fix MODULEINFO section.

Removed the extra space before "MODULEINFO" in res_pjsip_dlg_options.
This extra space prevented any of the dependencies from being seen by
menuselect, so building with default options would fail if PJSIP was
not installed.

This also makes the tool that extracts information for menuselect
tolerant of multiple spaces in the future.

ASTERISK-25033 #close
Reported by: Peter Whisker

Change-Id: Iccd54846f70c4a7a50cb5bf70b7bb5cb4bab3698
---
M build_tools/get_moduleinfo
M res/res_pjsip_dlg_options.c
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/35/335/1

diff --git a/build_tools/get_moduleinfo b/build_tools/get_moduleinfo
index 4dbb294..e4e72bb 100644
--- a/build_tools/get_moduleinfo
+++ b/build_tools/get_moduleinfo
@@ -1,4 +1,4 @@
-/\/\*\*\* MODULEINFO/ {printit=1; next}
+/\/\*\*\* +MODULEINFO/ {printit=1; next}
 /<support_level>/ {if (gotsupportlevel) { next }; gotsupportlevel=1}
 /\*\*\*\// {printit=0}
 /.*/ {if (printit) print}
diff --git a/res/res_pjsip_dlg_options.c b/res/res_pjsip_dlg_options.c
index 45a1940..3415124 100644
--- a/res/res_pjsip_dlg_options.c
+++ b/res/res_pjsip_dlg_options.c
@@ -16,7 +16,7 @@
  * at the top of the source tree.
  */
 
-/***  MODULEINFO
+/*** MODULEINFO
 	<depend>pjproject</depend>
 	<depend>res_pjsip</depend>
 	<depend>res_pjsip_session</depend>

-- 
To view, visit https://gerrit.asterisk.org/335
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccd54846f70c4a7a50cb5bf70b7bb5cb4bab3698
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>



More information about the asterisk-code-review mailing list