[Asterisk-code-review] Restrict functionality when ACLs are misconfigured. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Restrict functionality when ACLs are misconfigured.
......................................................................


Patch Set 1:

(1 comment)

I'm not going to -1 this change because I have a feeling that my comment is a separate fix and should apply to all active branches.

https://gerrit.asterisk.org/#/c/311/1/main/acl.c
File main/acl.c:

Line 482: 				ast_log(LOG_ERROR, "Named ACL '%s' occurs multiple times in ACL definition. Please update your ACL configuration.", tmp);
Lets consider the following being applied to an object:
acl=insideonly
acl=morestuff
acl=outsideonly
acl=insideonly

The user expectation would be that the order of evaluation would be (insideonly), morestuff, outsideonly, then insideonly.  The first insideonly wouldn't actually be evaluated since the following evaluation makes the first insignificant.

The current order of evaluation is insideonly, morestuff, then outsideonly.  This example is extreme, but it's the easiest way to make the point.  And obviously nobody would write a config as above, but this could happen when using templates.

I think if just remove the old item and let it get re-added we can just get rid of this error message.


-- 
To view, visit https://gerrit.asterisk.org/311
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ebcb6959cefad03cea4d81401be946203fcacae
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes