[Asterisk-code-review] Astobj2: Fix initialization order of refdebug and AO2 DEBUG. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Astobj2: Fix initialization order of refdebug and AO2_DEBUG.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/328/1/main/astobj2.c
File main/astobj2.c:

Line 912: 	if (container_init() != 0) {
        : 		return -1;
        : 	}
> Should you fclose(ref_log) here?
Actually in this case Asterisk needs to exit.  container_init will only return -1 if reg_containers failed to allocate.  In that case a segfault is coming.

I'll add the fclose anyways, but asterisk.c needs to check the return of astobj2_init and exit if failed.


-- 
To view, visit https://gerrit.asterisk.org/328
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a243ea3fc5653b48b931ba6d61971cb2e530244
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes