[Asterisk-code-review] channel: Remove ignore of answer on non-outgoing channels. (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: channel: Remove ignore of answer on non-outgoing channels.
......................................................................


Patch Set 1:

Terrifying, but given the discussion in #asterisk-dev (posted below), I think this is correct.

(01:05:15 PM) file: can I get a "are you sure you want to do that?" on 725 and 726?
(01:05:57 PM) mjordan: whoa.
(01:06:10 PM) mjordan: I'm not sure that's the right answer.
(01:06:21 PM) mjordan: Should we be clearing the OUTBOUND flag instead?
(01:08:19 PM) file: the bridge stuff explicitly clears it in a few places
(01:09:31 PM) file: specifically for CDRs
(01:10:19 PM) mjordan: correct
(01:10:28 PM) mjordan: if you don't clear the OUTBOUND flag, then 'bad things' will eventually occur
(01:10:39 PM) mjordan: So should we just be clearing the flag in whatever situation resulted in the problem?
(01:11:01 PM) file: I don't understand the question
(01:30:32 PM) mjordan: so the patch currently is simply removing a check to answer a channel if the OUTBOUND flag is on the channel
(01:30:49 PM) mjordan: I would presume that at some point in time, the OUTBOUND channel is no longer outbound, and hence the Answer we are attempting to do on it fails
(01:31:08 PM) mjordan: however, rather than removing the check, can we instead fix the actual issue where the OUTBOUND flag is not being cleared appropriately?
(01:32:32 PM) file: it removes a check preventing the channel from being able to queue up that it has been answered
(01:33:50 PM) file: reverse direction - it's not being told to answer, it's telling other stuff that it has been
(01:33:55 PM) mjordan: ah
(01:34:00 PM) mjordan: Hm.
(01:34:16 PM) mjordan: which channel in the blonde transfer is this pertaining to?
(01:35:08 PM) file: https://issues.asterisk.org/jira/browse/ASTERISK-25171
(01:35:18 PM) file: in that scenario, C
(01:36:25 PM) mjordan: right
(01:36:28 PM) mjordan: Hm.
(01:36:37 PM) mjordan: So C actually is still an outbound channel, unless it survives the bridge
(01:36:41 PM) mjordan: which means we shouldn't clear the flag yet
(01:36:45 PM) mjordan: ergo, the patch is correct.
(01:36:46 PM) mjordan: \o/

-- 
To view, visit https://gerrit.asterisk.org/725
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82aedcec4f89f34a2e5472086dfc9a6c775bca8e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No