[Asterisk-code-review] res pjsip outbound registration.c: Fix handle client state d... (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res_pjsip_outbound_registration.c: Fix handle_client_state_destruction() refs
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/707/1/res/res_pjsip_outbound_registration.c
File res/res_pjsip_outbound_registration.c:

Line 681: 
        : 
This debug message has been lost in the refactor.


Line 229: 	[SIP_REGISTRATION_STOPPING] = "Stopped",
Should this be "Stopping" instead of "Stopped"?


Line 694: 	struct registration_response *response = data;
In a lot of cases, it's a matter of personal taste whether to use RAII_VAR or not. This seems like a textbook case for its use, and since it already was being used, this seems like a move backwards to stop using it.


Line 719: 			if (registration_client_send(response->client_state, tdata) == PJ_SUCCESS) {
        : 				ao2_ref(response, -1);
        : 				return 0;
        : 			}
Why does control continue in this function on an unsuccessful registration attempt now?


-- 
To view, visit https://gerrit.asterisk.org/707
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b446d8644b6b4550ef5bea49527671de65183f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes