[Asterisk-code-review] sorcery: Add ast sorcery object unregister() API call. (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: sorcery: Add ast_sorcery_object_unregister() API call.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/705/1/main/sorcery.c
File main/sorcery.c:

Line 1116: 	if (object_type && object_type->type.type == ACO_ITEM) {
What circumstances would result in object_type->type.type not being ACO_ITEM?


Line 1122: 	/* XXX may need to add an instance unregister observer callback on success. */
I think George would be best qualified to chime in on this since the PJSIP config wizard is the only user of the object_type_registered observer.

I *think* for that case that an object_type_unregister would be unnecessary, though.


-- 
To view, visit https://gerrit.asterisk.org/705
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c04634fe9a90921bf676725c7d6bb2aeaab1c88
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes