[Asterisk-code-review] app dial: Hold reference to calling channel formats when dia... (asterisk[master])

Joshua Colp asteriskteam at digium.com
Wed Jun 24 13:51:02 CDT 2015


Joshua Colp has uploaded a new patch set (#2).

Change subject: app_dial: Hold reference to calling channel formats when dialing outbound.
......................................................................

app_dial: Hold reference to calling channel formats when dialing outbound.

Currently when requesting a channel the native formats of the
calling channel are provided to the core for usage when dialing
the outbound channel. This occurs without holding the channel lock
or keeping a reference to the formats. This is problematic as
the channel driver may end up changing the formats during this time.
In the case of chan_sip this happens when an SDP negotiation
completes.

This change makes it so app_dial keeps a reference to the native
formats of the calling channel which guarantees that they will
remain valid for the period of time needed.

ASTERISK-25172 #close

Change-Id: I2f0a67bd0d5d14c3bdbaae552b4b1613a283f0db
---
M apps/app_dial.c
1 file changed, 18 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/03/703/2
-- 
To view, visit https://gerrit.asterisk.org/703
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f0a67bd0d5d14c3bdbaae552b4b1613a283f0db
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list