[Asterisk-code-review] res pjsip outbound registration.c: Make use a serializer shu... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_outbound_registration.c: Make use a serializer shutdown group.
......................................................................


Patch Set 1:

(3 comments)

I'm going to wait for the first three patches in the series to get merged before pushing up the changes to this patch.

https://gerrit.asterisk.org/#/c/691/1//COMMIT_MSG
Commit Message:

Line 7:  Make use 
> 'Make use' is a little awkward. Maybe 'Add a ...'?
Done


https://gerrit.asterisk.org/#/c/691/1/res/res_pjsip_outbound_registration.c
File res/res_pjsip_outbound_registration.c:

Line 1828: 	ast_debug(1, "Waiting for things to settle to unload.\n");
> Two suggestions:
1) Very few ast_debug statements use a debug level other than 1.  I've changed the level to 2.

2) Before the shutdown_group existing I had more than one thing that causing the wait.  I've changed the wording to be more specific.


Line 1836: 		ast_log(LOG_NOTICE, "Incomplete unload.  Try again later.  (%d remaining).\n",
> Why NOTICE? Why was it incomplete? What is remaining? If I'm a user seeing 
I've changed the severity to a warning.  This message should not be seen very often because the timeout (35 seconds) is long enough to allow SIP transactions to complete most of the time.

If you were a user seeing this you would only care about the first two statements:  "Incomplete unload" and "try again later".  Though some users refuse to read and ask in IRC anyway.  I've added "Does the peer exist?" as further help.


-- 
To view, visit https://gerrit.asterisk.org/691
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb2fe558f98190f2a06da830e0fadfa25516f547
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes