[Asterisk-code-review] Stasis attended transfers: No StasisEnd event for transfer t... (testsuite[master])

Kevin Harwell asteriskteam at digium.com
Tue Jun 23 09:53:39 CDT 2015


Kevin Harwell has posted comments on this change.

Change subject: Stasis attended transfers: No StasisEnd event for transfer target channel
......................................................................


Patch Set 1:

>Do the full descriptions at the top of the tests need to be updated at all as well?

They all should be fine. However I can make one minor adjustment to two of them.

>I know we had a tough time figuring out what all each test was >covering. I think a review of the test descriptions is justified.

There was just a single test (not part of this review) that initially was a bit confusing. However after carefully re-reading its description I believe it is fine and makes sense. At the time I was having a bit of trouble understanding how the Asterisk code was handling things.

-- 
To view, visit https://gerrit.asterisk.org/693
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife584d91394ff69a3662004471421761789c4901
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list