[Asterisk-code-review] res pjsip outbound registration.c: Fix handle client state d... (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Tue Jun 23 09:50:32 CDT 2015


Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_outbound_registration.c: Fix handle_client_state_destruction() refs
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/689/1/res/res_pjsip_outbound_registration.c
File res/res_pjsip_outbound_registration.c:

Line 229: 	[SIP_REGISTRATION_STOPPING] = "Stopped",
> Why Stopped and not Stopping?
This version of the string has a slightly better chance than the pre-existing "Stopped" string to show up in AMI action output for PJSIPShowRegistrationsOutbound.  Since the string could show up in AMI output I chose to reuse an existing string.  The only time I think it will show is if the AMI action is in progress on one thread while another thread is unloading the module.


-- 
To view, visit https://gerrit.asterisk.org/689
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b446d8644b6b4550ef5bea49527671de65183f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list