[Asterisk-code-review] sorcery: Add ast sorcery object unregister() API call. (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Tue Jun 23 09:35:41 CDT 2015


Richard Mudgett has posted comments on this change.

Change subject: sorcery: Add ast_sorcery_object_unregister() API call.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/687/1/main/sorcery.c
File main/sorcery.c:

Line 1122: 	/* XXX may need to add an instance unregister observer callback on success. */
> I think we're fine without a callback here, nothing springs to mind of what
OK  I'll just leave the comment here though.  I couldn't add the callback to v13 because that would change ABI compatibility.


-- 
To view, visit https://gerrit.asterisk.org/687
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c04634fe9a90921bf676725c7d6bb2aeaab1c88
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list