[Asterisk-code-review] res rtp asterisk.c: don't call dtls perform handshake while ... (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: res_rtp_asterisk.c: don't call dtls_perform_handshake while passive
......................................................................


Patch Set 1:

I'm going to go ahead and close out this review.

While I think we all appreciate the attempt at solving ASTERISK-24832 - which is clearly a nasty issue - without fully understanding the problem, patching Asterisk is not a good idea. Doing so has a tendency to only create additional problems, while making the original problem harder to understand and more difficult to solve.

Hopefully the community can determine what is causing the errant behaviour, and a patch can be written. If at any point you feel like you have a good handle on what may be causing the issue, please do comment on the issue, or post an e-mail to the asterisk-dev list.

Thanks!

-- 
To view, visit https://gerrit.asterisk.org/490
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I156bd07323eb8c7f99f59fcfe560ce9c3ae60e36
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Stefan Engström <stefanen at kth.se>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No