[Asterisk-code-review] chan sip.c: Start ICE negotiation when response is sent or r... (asterisk[11])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: chan_sip.c: Start ICE negotiation when response is sent or received.
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/679/4/channels/chan_sip.c
File channels/chan_sip.c:

Line 10522:                         if(req->method == SIP_RESPONSE){
Spaces according to the coding guidelines.


Line 10523:                                 start_ice(p->rtp,(req->method != SIP_RESPONSE) ? 0 : 1);
The req->method != SIP_RESPONSE logic will never be true, since this is now only done when the request is a response.


-- 
To view, visit https://gerrit.asterisk.org/679
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife7fd7d65026393bd4b09805aa788ea358ec3c35
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Eugene Voityuk <eugene at thirdlane.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes