[Asterisk-code-review] chan sip.c: Start ICE checking in proper time. (asterisk[11])

[Eugene Voityuk]

Eugene Voityuk has uploaded a new patch set (#3).

Change subject: chan_sip.c: Start ICE checking in proper time.
......................................................................

chan_sip.c: Start ICE checking in proper time.

Right now asterisk start ice checking on any sdp with
ice candidates which is wrong,
because browsers start ice checking only after
they have remote description.
In current implementation, when any WebRTC extension
is sending INVITE with ICE candidates,
it will immediately start pj_ice_sess_start_check,
which will try to do checking and fill fire callback with failed status,
for this to happen you have ~7 seconds
(browser should set remote description before callback is failed),
if remote pick's up after callback is fire
you will have no audio in both directions.
This commit fixes this issue, by calling ice_start, only for responses.
I was also trying to add more logic to res_rtp_asterisk.c,
but that is beyond of my understanding.

ASTERISK-24146

Change-Id: Ife7fd7d65026393bd4b09805aa788ea358ec3c35
---
M channels/chan_sip.c
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/79/679/3
-- 
To view, visit https://gerrit.asterisk.org/679
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife7fd7d65026393bd4b09805aa788ea358ec3c35
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Eugene Voityuk <eugene at thirdlane.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>