[Asterisk-code-review] media cache: Add a core API and facade for a backend agnosti... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: media cache: Add a core API and facade for a backend agnostic media cache
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/487/2/main/media_cache.c
File main/media_cache.c:

Line 236: 		ast_bucket_file_update(clone);
This doesn't do what you want it to.

What you want is a function that given a bucket file will determine if that local bucket file structure differs from the what is stored in backend storage. This doesn't exist and I'm not sure of a nice way to add it.

This goes the opposite direction. I have a local bucket file structure, I've made local changes, and then I want to commit them to backend storage.

I think what would be useful here is information about what you need the bucket API to provide and do.


-- 
To view, visit https://gerrit.asterisk.org/487
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11227abbf14d8929eeb140ddd101dd5c3820391e
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes