[Asterisk-code-review] Skip rest api tests that are failing. (testsuite[master])

Corey Farrell asteriskteam at digium.com
Wed Jun 17 11:12:15 CDT 2015


Corey Farrell has posted comments on this change.

Change subject: Skip rest_api tests that are failing.
......................................................................


Patch Set 1:

> The test that resulted in the creation of ASTERISK-24782 received
 > some updates after the Asterisk fix. I believe these tests may need
 > similar changes. See http://git.asterisk.org/gitweb/?p=asterisk/testsuite.git;a=commit;h=8b99b92a0593f016a521991dc5194b509628d8e5

The review for that fix was https://gerrit.asterisk.org/c/125/.  Per the review that test was failing about 1/5 of the time.  These three tests are failing every single time.  I'm not sure I can make these tests work correctly, I don't want to copy/paste changes that I don't really understand.

If someone else posts a review that will make these 3 tests actually work, I can abandon this change.  Otherwise we should disable them for now and reopen ASTERISK-24782.  Running them in the current form is a complete waste of resources since the result is effectively ignored.  They always report failure when running REF_DEBUG since Asterisk doesn't cleanly shutdown.

-- 
To view, visit https://gerrit.asterisk.org/667
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ca7da1fd01031846994f3b18ac551f2b51320d
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: John Bigelow <jbigelow at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list