[Asterisk-code-review] media cache: Add a core API and facade for a backend agnosti... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: media cache: Add a core API and facade for a backend agnostic media cache
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/487/1/main/media_cache.c
File main/media_cache.c:

Line 216: 		ast_bucket_file_update(bucket_file);
> This is really asking the bucket backend to check the system it interacts w
For updating the backend you can use ast_bucket_file_copy to create a copy and then manipulate it all you want. This also ensures that anything accessing the underlying file won't have the file change in interesting ways while accessing it.

What you need is a retrieve_if_changed which doesn't currently exist.


-- 
To view, visit https://gerrit.asterisk.org/487
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11227abbf14d8929eeb140ddd101dd5c3820391e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes