[Asterisk-code-review] res pjsip: Add option to use g.726 for AAL2 packing when neg... (asterisk[13])

Matt Jordan asteriskteam at digium.com
Sun Jun 14 11:06:02 CDT 2015


Matt Jordan has posted comments on this change.

Change subject: res_pjsip: Add option to use g.726 for AAL2 packing when negotiating g.726
......................................................................


Patch Set 1: Code-Review-1

Since this is a new option, it really does need a test in the Test Suite. At a minimum, we should test the SDP negotiation.

I'd add a test to the SDP negotiation tests that covers the absence/presence of the configuration parameter.

-- 
To view, visit https://gerrit.asterisk.org/651
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7e21f75493d7fe53e75e12c971e72f5afa33615
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list