[Asterisk-code-review] chan sip: Prevent deadlock when performing BYE with Also tra... (asterisk[11])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: chan_sip: Prevent deadlock when performing BYE with Also transfer.
......................................................................


Patch Set 2:

> The fix here is clearly very simple. It's also pretty clear that
 > not many people send an Also: header in a BYE request, as this
 > would have caused a problem in chan_sip since the early days of
 > Asterisk 1.8.
 > 
 > That being said, should we have a test for this? I'm not sure how
 > easy it is to make SIPp do this, but it may be worthwhile just so
 > that this never crops up again.

I actually used SIPp to reproduce the issue in the first place. If I had a SIPp scenario issue 10 simultaneous calls and then send a BYE with Also header, I'd typically see the deadlock happen.

I could write a test that does a similar thing. The test has the possibility to pass even without this fix, but with this fix, the test should pass every time.

-- 
To view, visit https://gerrit.asterisk.org/644
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72c4fc295ec8573bee599e8e9213c5350a3cd224
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No