[Asterisk-code-review] chan sip.c: Update dialog fromtag after request with auth (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: chan_sip.c: Update dialog fromtag after request with auth
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/632/5//COMMIT_MSG
Commit Message:

Line 33: 
       : Fixed error to make it compile
       : 
       : Change-Id: I5c16cf3b409e5ef9f2b2fe974b6bd2a45a6aa17e
       : 
       : Moved lock/unlock to be outside the if()
       : 
       : Change-Id: I5c16cf3b409e5ef9f2b2fe974b6bd2a45a6aa17e
When you squash the commits you can edit the commit message.
You should have edited these lines out.


https://gerrit.asterisk.org/#/c/632/5/channels/chan_sip.c
File channels/chan_sip.c:

Line 9117: 						&& strcmp(args.fromtag, sip_pvt_ptr.theirtag)) {
You still have not fixed the compiler error on this line yet.
sip_pvt_ptr.theirtag  <--- This is wrong
sip_pvt_ptr->theirtag <--- This is correct


-- 
To view, visit https://gerrit.asterisk.org/632
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c16cf3b409e5ef9f2b2fe974b6bd2a45a6aa17e
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Damian Ivereigh <damo at launtel.net.au>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes