[Asterisk-code-review] DNS: Need to use the same serializer for a pjproject SIP tra... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: DNS: Need to use the same serializer for a pjproject SIP transaction.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/627/3/res/res_pjsip.c
File res/res_pjsip.c:

Line 3391: 	if (serializer) {
         : 		return ast_taskprocessor_push(serializer, sip_task, task_data);
         : 	} else {
         : 		return ast_threadpool_push(sip_threadpool, sip_task, task_data);
         : 	}
> Should it ever be possible for no serializer to exist here now? Should ther
The only way that it could be NULL now is if the creation of the serializer pool failed or the system is shutting down.  I'm not sure how much an assert is going to help here over the protection of simply pushing the task into the threadpool.


-- 
To view, visit https://gerrit.asterisk.org/627
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea71c16ce1132017b5791635e198b8c27973f40a
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes