[Asterisk-code-review] DNS: Need to use the same serializer for a pjproject SIP tra... (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: DNS: Need to use the same serializer for a pjproject SIP transaction.
......................................................................


Patch Set 1:

(1 comment)

Overall, this is excellent work. I just had one question.

https://gerrit.asterisk.org/#/c/627/1/res/res_pjsip.c
File res/res_pjsip.c:

Line 3380: 		pos = ast_atomic_fetchadd_int(&serializer_pool_pos, 1);
Does this really need to be atomic? If there is some sort of race that causes two threads to pick the same value for pos, or if there is some race that results in a serializer being skipped, that's not really a big deal. I'm not sure if the cost of making this an atomic operation is worth it.


-- 
To view, visit https://gerrit.asterisk.org/627
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea71c16ce1132017b5791635e198b8c27973f40a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes