[Asterisk-code-review] pjsip resolver.c: Fix debug code to only execute at acceptab... (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Wed Jun 10 13:36:59 CDT 2015


Richard Mudgett has posted comments on this change.

Change subject: pjsip_resolver.c: Fix debug code to only execute at acceptable debug level.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/625/1/res/res_pjsip/pjsip_resolver.c
File res/res_pjsip/pjsip_resolver.c:

Line 202: 	ast_debug(2, "[%p] Invoking user callback with '%d' addresses\n", resolve, resolve->addresses.count);
> Nit: why not move this line into the if block as well?
1) It is part of a different message.
2) It could be moved.
3) I didn't think of doing that. :)


-- 
To view, visit https://gerrit.asterisk.org/625
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1716c93d6e097ad28128ecb9e806aac7a4180c8a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list