[Asterisk-code-review] Fix test: caller initiated attended transfer w/Replaces, dir... (testsuite[master])

Joshua Colp asteriskteam at digium.com
Tue Jun 9 17:45:49 CDT 2015


Joshua Colp has submitted this change and it was merged.

Change subject: Fix test: caller initiated attended transfer w/Replaces, direct media, hold
......................................................................


Fix test: caller initiated attended transfer w/Replaces, direct media, hold

The test has been bouncing due to an additional occurrence of an event.
This should fix the test from bouncing by allowing more than one
occurrence of the event while only performing the hold on the first
occurrence.

Change-Id: I75203088be1c7833695f132655befde9086b09cf
---
M tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_direct_media/test-config.yaml
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Verified



diff --git a/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_direct_media/test-config.yaml b/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_direct_media/test-config.yaml
index ccc971b..74328cb 100644
--- a/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_direct_media/test-config.yaml
+++ b/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_direct_media/test-config.yaml
@@ -88,6 +88,8 @@
             pjsua_account: 'alice'
             call_uri: 'sip:101 at 127.0.0.1'
     # Ensure alice and bob are remotely bridged. Then alice places bob on hold.
+    # The remote bridge may be setup twice depending on how fast things occur
+    # but the hold is only executed upon the first occurrence of the event.
     -
         ami-events:
             conditions:
@@ -96,7 +98,8 @@
                     UserEvent: 'RemoteRTPBridgeStarted'
                     Endpoint1: '(bob|alice)'
                     Endpoint2: '(bob|alice)'
-            count: 1
+            count: '>1'
+            trigger-on-count: True
         pjsua_phone:
             action: 'hold'
             pjsua_account: 'alice'

-- 
To view, visit https://gerrit.asterisk.org/606
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I75203088be1c7833695f132655befde9086b09cf
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: John Bigelow <jbigelow at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>



More information about the asterisk-code-review mailing list