[Asterisk-code-review] install prereq: Check if is installed aptitude otherwise to ... (asterisk[master])
Rodrigo Ramirez Norambuena
asteriskteam at digium.com
Sun Jun 7 19:01:39 CDT 2015
Rodrigo Ramirez Norambuena has posted comments on this change.
Change subject: install_prereq: Check if is installed aptitude otherwise to install.
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.asterisk.org/#/c/508/2/contrib/scripts/install_prereq
File contrib/scripts/install_prereq:
Line 74: if ! [ ${#pkgs} -gt 0 ]; then
> Isn't the logic on this backwards? Right now it will output only if $pkgs
You are right. Is little deslice on the validated.
--
To view, visit https://gerrit.asterisk.org/508
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebdff55805d3917166e5e08e0a1e2176f36ff27f
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list