[Asterisk-code-review] res pjsip transport websocket: Fix use-after-free bugs. (asterisk[master])

[Ivan Poddubny]

Ivan Poddubny has posted comments on this change.

Change subject: res_pjsip_transport_websocket: Fix use-after-free bugs.
......................................................................


Patch Set 2:

PJSIP documentation states [1] that the group locks were introduced in version 2.1, and the API doesn't seem to have changed much since then [2], so I don't think this should be that much of a problem.

Using astobj2 without an object (worse, with a dummy object to prevent flooding logs with warnings) just for a refcounter with a destructor does not feel right to me. If only the transport itself was allocated by ao2, then I think it would be ok.

[1] https://trac.pjsip.org/repos/wiki/Group_Lock
[2] http://www.pjsip.org/docs/2.1/pjlib/docs/html/group__PJ__GRP__LOCK.htm

-- 
To view, visit https://gerrit.asterisk.org/598
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc0b63eb6e459c1ddfb2430127d34b3c4d8d373b
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Reviewer: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No