[Asterisk-code-review] Cosmetic issue - core show uptime (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Cosmetic issue - core show uptime
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/586/1//COMMIT_MSG
Commit Message:

Line 7: Cosmetic issue - core show uptime
CLI: Cosmetic issue - core show uptime.


https://gerrit.asterisk.org/#/c/586/1/main/cli.c
File main/cli.c:

Line 786: 		ast_str_append(&out, 0, "%d year%s%s", x, ESS(x),NEEDCOMMA(timeval.tv_sec));
Since you touched this line and several others below.
Guidelines: Space after comma on function parameters.


Line 809: 	if (x > 0 || ast_str_strlen(out) == 0)	/* if there is nothing, print 0 seconds */
        : 		ast_str_append(&out, 0, "%d second%s", x, ESS(x));
Since you touched this line:
Guidelines: Curly braces should be added to the if statement here.


-- 
To view, visit https://gerrit.asterisk.org/586
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11b360504a0703309ff51772ff8f672287f3c5a1
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: ibercom <ibercom123 at gmail.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes