[Asterisk-code-review] Provide SCOPED LOCK variant for AST RWLIST. (asterisk[master])

Joerg Sonnenberger asteriskteam at digium.com
Wed Jun 3 04:02:30 CDT 2015


Joerg Sonnenberger has posted comments on this change.

Change subject: Provide SCOPED_LOCK variant for AST_RWLIST.
......................................................................


Patch Set 1:

As I wrote, the current use of AST_RWLIST_UNLOCK as dtor enforces the tight binding of wrapper function definition and cleanup attribute. It is not a function by itself and it doesn't expand to a fixed type expression, but is polymorphic under the value type. This is the only case in the normal source code of Asterisk that behaves like that and IMO by itself poor code.

-- 
To view, visit https://gerrit.asterisk.org/573
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I201fb77d68ef56f5e0388b256c4c0d624c0277e8
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joerg Sonnenberger <joerg at bec.de>
Gerrit-Reviewer: Joerg Sonnenberger <joerg at bec.de>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list