[Asterisk-code-review] cdr/cdr csv.c: Set file name for csv master to the module wh... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: cdr/cdr_csv.c: Set file name for csv master to the module when (re)loaded.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/404/2/cdr/cdr_csv.c
File cdr/cdr_csv.c:

Line 126: 	ast_mutex_lock(&fname_lock);
Adding a new lock does not fix the race condition.  The race is between changing file_csv_master here and reading it in csv_log().  You should be using the already existing f_lock lock instead.


-- 
To view, visit https://gerrit.asterisk.org/404
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ed9f6a8f965308099db70b71128f43d4d3f5585
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes