[Asterisk-code-review] res rtp asterisk.c: Fix off-nominal crash potential. (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Fri Jul 31 17:15:40 CDT 2015


Kevin Harwell has posted comments on this change.

Change subject: res_rtp_asterisk.c: Fix off-nominal crash potential.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/1016/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 4507: 	if (!payload) {
         : 		/* Unknown payload type. */
         : 		return AST_LIST_FIRST(&frames) ? AST_LIST_FIRST(&frames) : &ast_null_frame;
         : 	}
> I'm not sure that would be such a good idea as it would have the potential 
Maybe something with a high debug level? I guess I am good either way.


-- 
To view, visit https://gerrit.asterisk.org/1016
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08549fb7c3ab40a559f41a3940f3732a4059b55b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list