[Asterisk-code-review] ARI: Retrieve existing log channels (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: ARI: Retrieve existing log channels
......................................................................


Patch Set 9: Code-Review-1

(2 comments)

As a note, be sure to look at the "master" review as there are some things mentioned there that need to be addressed here as well (it just looks like you uploaded a new patch and may have missed those).

https://gerrit.asterisk.org/#/c/986/9/main/logger.c
File main/logger.c:

Line 1079: 		logentry(chan->filename, chan->type == LOGTYPE_CONSOLE ? "Console" :
         : 			(chan->type == LOGTYPE_SYSLOG ? "Syslog" : "File"), chan->disabled ?
         : 			"Disabled" : "Enabled", ast_str_buffer(configs), data);
This should check the result of the callback and fail/return appropriately.


https://gerrit.asterisk.org/#/c/986/9/res/ari/resource_asterisk.c
File res/ari/resource_asterisk.c:

Line 666: 	ast_logger_get_channels(&process_log_list, json);
This should check the result of ast_logger_get_channels and return the appropriate response on failure.


-- 
To view, visit https://gerrit.asterisk.org/986
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bb08b93e3b938c991f3f56cc5d188654768a808
Gerrit-PatchSet: 9
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Scott Emidy <jemidy at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Scott Emidy <jemidy at digium.com>
Gerrit-HasComments: Yes